ENH: add na_action to Categorical.map & CategoricalIndex.map #51645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
categorical_map_na_Action
branch
from
5674674
to
10f8606
Compare
topper-123
force-pushed
the
categorical_map_na_Action
branch
2 times, most recently
from
6b461b2
to
64b7297
Compare
mroeschke
reviewed
Mar 17, 2023
mroeschke
reviewed
Mar 17, 2023
mroeschke
reviewed
Mar 17, 2023
|
I've updated again. I noticed that the implicit default for So I've set the default value of |
topper-123
force-pushed
the
categorical_map_na_Action
branch
from
7775e2b
to
dc60e20
Compare
topper-123
force-pushed
the
categorical_map_na_Action
branch
from
1f19c3e
to
dc9d119
Compare
|
I’ve simplified the implementation. |
topper-123
force-pushed
the
categorical_map_na_Action
branch
from
1fc89b7
to
be2d451
Compare
|
Ping. |
mroeschke
reviewed
Mar 29, 2023
pandas/core/apply.py
Outdated
| mapped = obj._map_values(mapper=f, convert=self.convert_dtype) | ||
| # apply doesn't have a `na_action` keyword and for backward compat reasons | ||
| # we need to give `na_action="ignore"` for categorical data. | ||
| # TODO: remove the `na_action="ignore"` has been removed from Categorical. |
There was a problem hiding this comment.
Is this supposed to refer to once the deprecation is enforced?
mroeschke
reviewed
Mar 29, 2023
pandas/core/arrays/categorical.py
Outdated
|
|
||
| .. deprecated:: 2.1.0 | ||
|
|
||
| The dault value of 'ignore' has been deprecated and will be changed to |
There was a problem hiding this comment.
Suggested change
| The dault value of 'ignore' has been deprecated and will be changed to | |
| The default value of 'ignore' has been deprecated and will be changed to |
mroeschke
reviewed
Mar 30, 2023
mroeschke
approved these changes
Mar 30, 2023
|
Thanks @topper-123 |
topper-123
added a commit
to topper-123/pandas
that referenced
this pull request
Apr 1, 2023
…dev#51645) * ENH: add na_action to Categorical.map * add GH numbers * pre-commit issues * map Categorical with Series * REF: simplify .map * pass test_map * fix whatsnew * cleanups * pre-commit * deprecate Categorical.map(na_action=ignore) * fix docstrings * fix rebase * simplity implementation * fix warn * fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.