-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REGR: Performance of DataFrame reduction ops with axis=1 #52689
REGR: Performance of DataFrame reduction ops with axis=1 #52689
Conversation
------- | ||
arr : ndarray | ||
""" | ||
# # TODO(CoW) handle case where resulting array is a view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche - I don't understand this TODO, can you give more details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I suppose that with the currently implementation, the resulting arrays are never views but always copies? (since result_data
and result_mask
are newly created arrays (and then the values are copied in)
In that case I think you can just remove the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that was just copied from the as_array
implementation above, then can certainly be removed. Sorry for the confusion!
…ction_ops_perf_transpose
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Siphoning off the largest impact from #52083.