Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: FloatingArray.__contains__(nan) #52840

Merged
merged 7 commits into from
May 1, 2023
Merged

BUG: FloatingArray.__contains__(nan) #52840

merged 7 commits into from
May 1, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

More targeted version of #51378

@rhshadrach rhshadrach added Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Apr 22, 2023
@mroeschke
Copy link
Member 

 mypy.....................................................................Failed
- hook id: mypy
- duration: 140.36s
- exit code: 1

pandas/core/arrays/masked.py:245: error: Incompatible return value type (got "Union[bool, bool_]", expected "bool")  [return-value]
Found 1 error in 1 file (checked 1420 source files)

@mroeschke mroeschke added this to the 2.1 milestone May 1, 2023
@mroeschke mroeschke merged commit f886f13 into pandas-dev:main May 1, 2023
29 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the bug-contains-2 branch May 1, 2023 18:01
NumanIjaz pushed a commit to NumanIjaz/pandas that referenced this pull request May 1, 2023
@jbrockmendel @phofl @NumanIjaz
BUG: FloatingArray.__contains__(nan) (pandas-dev#52840)
216557c 
* BUG: FloatingArray.__contains__(nan)

* GH ref

* mypy fixup

* mypy fixup

---------

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
@jbrockmendel @phofl @topper-123
BUG: FloatingArray.__contains__(nan) (pandas-dev#52840)
418a340 
* BUG: FloatingArray.__contains__(nan)

* GH ref

* mypy fixup

* mypy fixup

---------

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@jbrockmendel @phofl
BUG: FloatingArray.__contains__(nan) (pandas-dev#52840)
a5cc54a 
* BUG: FloatingArray.__contains__(nan)

* GH ref

* mypy fixup

* mypy fixup

---------

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@jbrockmendel @phofl @im-vinicius
BUG: FloatingArray.__contains__(nan) (pandas-dev#52840)
9e948e6 
* BUG: FloatingArray.__contains__(nan)

* GH ref

* mypy fixup

* mypy fixup

---------

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbrockmendel @mroeschke @rhshadrach @phofl