Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGR: SeriesGroupBy.agg with multiple categoricals, as_index=False, and a list fails #52850

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach added Bug Groupby Regression Functionality that used to work in a prior pandas version Categorical Categorical Data Type Apply Apply, Aggregate, Transform Reduction Operations sum, mean, min, max, etc. labels Apr 22, 2023
@rhshadrach rhshadrach added this to the 2.0.1 milestone Apr 22, 2023
@rhshadrach rhshadrach removed the Reduction Operations sum, mean, min, max, etc. label Apr 22, 2023
@phofl phofl merged commit 2ac0da4 into pandas-dev:main Apr 22, 2023
43 of 44 checks passed
@phofl
Copy link
Member

phofl commented Apr 22, 2023

thx @rhshadrach

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 22, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.0.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2ac0da4e129c78b41a1bf9c8c4a5b751c0bae408
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #52850: REGR: SeriesGroupBy.agg with multiple categoricals, as_index=False, and a list fails'
  1. Push to a named branch:
git push YOURFORK 2.0.x:auto-backport-of-pr-52850-on-2.0.x
  1. Create a PR against branch 2.0.x, I would have named this PR:

"Backport PR #52850 on branch 2.0.x (REGR: SeriesGroupBy.agg with multiple categoricals, as_index=False, and a list fails)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

phofl pushed a commit to phofl/pandas that referenced this pull request Apr 22, 2023
phofl added a commit that referenced this pull request Apr 22, 2023
…iple categoricals, as_index=False, and a list fails) (#52854)

* REGR: SeriesGroupBy.agg with multiple categoricals, as_index=False, and a list fails (#52850)

(cherry picked from commit 2ac0da4)

* Fixup for 2.0.x

---------

Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
@rhshadrach rhshadrach deleted the gb_agg_regr branch April 25, 2023 02:06
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform Bug Categorical Categorical Data Type Groupby Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: groupby.agg raises KeyError: "['col1', 'col5'] not found in axis"
2 participants