Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Adding a columns to a Frame with RangeIndex columns using a non-scalar key #52877

Merged
merged 3 commits into from
Apr 23, 2023

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 changed the title BUG: Adding a columns to a Frame using a non-scalar key BUG: Adding a columns to a Frame with RangeIndex columns using a non-scalar key Apr 23, 2023
@phofl
Copy link
Member

phofl commented Apr 23, 2023

Thanks for taking a look. Could you label regression fixes immediately as 2.0.x while opening? Makes prioritising PR reviews easier

@phofl phofl added this to the 2.0.1 milestone Apr 23, 2023
@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version labels Apr 23, 2023
@phofl phofl merged commit 09b1966 into pandas-dev:main Apr 23, 2023
@phofl
Copy link
Member

phofl commented Apr 23, 2023

thx @topper-123

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 23, 2023
@topper-123 topper-123 deleted the range_index_non_scalar_hashable branch April 23, 2023 14:37
phofl pushed a commit that referenced this pull request Apr 23, 2023
…with RangeIndex columns using a non-scalar key) (#52881)

Backport PR #52877: BUG: Adding a columns to a Frame with RangeIndex columns using a non-scalar key

Co-authored-by: Terji Petersen <terji78@gmail.com>
topper-123 added a commit to topper-123/pandas that referenced this pull request Apr 27, 2023
topper-123 added a commit to topper-123/pandas that referenced this pull request May 1, 2023
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
topper-123 added a commit to topper-123/pandas that referenced this pull request May 27, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
mroeschke pushed a commit that referenced this pull request Jul 13, 2023
* ENH: better dtype inference when doing DataFrame reductions

* precommit issues

* fix failures

* fix failures

* mypy + some docs

* doc linting linting

* refactor to use _reduce_with_wrap

* docstring linting

* pyarrow failure + linting

* pyarrow failure + linting

* linting

* doc stuff

* linting fixes

* fix fix doc string

* remove _wrap_na_result

* doc string example

* pyarrow + categorical

* silence bugs

* silence errors

* silence errors II

* fix errors III

* various fixups

* various fixups

* delay fixing windows and 32bit failures

* BUG: Adding a columns to a Frame with RangeIndex columns using a non-scalar key (#52877)

* DOC: Update whatsnew (#52882)

* CI: Change development python version to 3.10 (#51133)

* CI: Change development python version to 3.10

* Update checks

* Remove strict

* Remove strict

* Fixes

* Add dt

* Switch python to 3.9

* Remove

* Fix

* Try attribute

* Adjust

* Fix mypy

* Try fixing doc build

* Fix mypy

* Fix stubtest

* Remove workflow file

* Rename back

* Update

* Rename

* Rename

* Change python version

* Remove

* Fix doc errors

* Remove pypy

* Update ci/deps/actions-pypy-39.yaml

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>

* Revert pypy removal

* Remove again

* Fix

* Change to 3.9

* Address

---------

Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>

* update

* update

* add docs

* fix windows tests

* fix windows tests

* remove guards for 32bit linux

* add bool tests + fix 32-bit failures

* fix pre-commit failures

* fix mypy failures

* rename _reduce_with -> _reduce_and_wrap

* assert missing attributes

* reduction dtypes on windows and 32bit systems

* add tests for min_count=0

* PERF:median with axis=1

* median with axis=1 fix

* streamline Block.reduce

* fix comments

* FIX preserve dtype with datetime columns of different resolution when merging (#53213)

* BUG Merge not behaving correctly when having `MultiIndex` with a single level (#53215)

* fix merge when MultiIndex with single level

* resolved conversations

* fixed code style

* BUG: preserve dtype for right/outer merge of datetime with different resolutions (#53233)

* remove special BooleanArray.sum method

* remove BooleanArray.prod

* fixes

* Update doc/source/whatsnew/v2.1.0.rst

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

* Update pandas/core/array_algos/masked_reductions.py

Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>

* small cleanup

* small cleanup

* only reduce 1d

* fix after #53418

* update according to comments

* revome note

* update _minmax

* REF: add keepdims parameter to ExtensionArray._reduce + remove ExtensionArray._reduce_and_wrap

* REF: add keepdims parameter to ExtensionArray._reduce + remove ExtensionArray._reduce_and_wrap

* fix whatsnew

* fix _reduce call

* simplify test

* add tests for any/all

---------

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Yao Xiao <108576690+Charlie-XIAO@users.noreply.github.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pandas 2.0.0 may raise InvalidIndexError when assigning a column with an enum as label
2 participants