Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove 32 bit testing #53246

Closed
wants to merge 1 commit into from
Closed

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented May 15, 2023

With the meson build PR, we dropped windows 32 bit wheels. Additionally, other pydata libraries are also starting to remove 32 bit wheel support https://discuss.python.org/t/dropping-32-bit-packages/5476/9. Since we don't ship these wheels anymore, I am not sure if we should continue to test this specifically.

@mroeschke mroeschke added CI Continuous Integration 32bit 32-bit systems labels May 15, 2023
@eli-schwartz
Copy link
Contributor

eli-schwartz commented May 15, 2023

This was also previously discussed in e.g. #15889 and the consensus seemed to be that it's worth supporting 32-bit builds in source, even though wheels would not be published. Especially:

Moreover, my very general and superficial analysis of issues like #24613 (or - now speaking out of experience - #19439 ) is that they actually help us fix mistakes in the code, regardless of the use of 32 bits.

Seems like the challenge of windows 32-bit release wheels shouldn't reflect on the challenge of running CI on linux.

@mroeschke
Copy link
Member Author

Ah okay. I suppose we can keep this around and support those who install from source on 32 bit platforms. Closing

@mroeschke mroeschke closed this May 15, 2023
@thesamesam
Copy link
Contributor

In #44453, I also say:

Apologies if I'm misunderstanding here, but it looks like Numpy isn't dropping 32-bit support numpy/numpy#20277 (comment). It looks like they're only dropping wheel generation because of infra constraints but will continue to test.

I'm interested because in Gentoo, we still support a number of 32-bit architectures (arm, x86 being the two main ones), and Pandas ends up in the depgraph often unavoidably if we want to run test suites on programs.

Is the plan for Pandas to drop support entirely for 32-bit or to just stop producing wheels?

Numpy continues to have this position, per https://discuss.python.org/t/dropping-32-bit-packages/5476/16.

@mroeschke mroeschke deleted the ci/cln/32 branch May 15, 2023 23:35
@thesamesam
Copy link
Contributor

Ah okay. I suppose we can keep this around and support those who install from source on 32 bit platforms. Closing

Thank you! It is really appreciated, I promise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: 32 bit build does not work with -Werror BLD: remove support for 32 bit Migrate 32-bit linux build
3 participants