ExtensionArray.Round method and tests #54582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
ExtensionArray
mroeschke
reviewed
Sep 1, 2023
jbrockmendel
reviewed
Sep 6, 2023
jbrockmendel
reviewed
Sep 6, 2023
jbrockmendel
reviewed
Sep 6, 2023
jbrockmendel
reviewed
Sep 6, 2023
andrewgsavage
commented
Sep 6, 2023
jbrockmendel
reviewed
Oct 9, 2023
| @@ -349,6 +349,10 @@ def test_map_raises(self, data, na_action): | |||
| with pytest.raises(ValueError, match=msg): | |||
| data.map(lambda x: np.nan, na_action=na_action) | |||
|
|
|||
| @pytest.mark.xfail(reason="SparseArray.round not implemented.") | |||
There was a problem hiding this comment.
why doesnt the base class implementation work here?
|
Any pointers on how to get mypy to accept two function signitures for round? Datetimelikes get overridden: gets overridden by |
|
If the typing overload decorator doesn't work I think in this case it's OK to ignore the mypy failures since it's a known differnece. |
mroeschke
reviewed
Nov 8, 2023
| @@ -1094,7 +1094,8 @@ def round(self, decimals: int = 0, *args, **kwargs) -> Self: | |||
| DataFrame.round : Round values of a DataFrame. | |||
| Series.round : Round values of a Series. | |||
| """ | |||
| return type(self)(pc.round(self._pa_array, ndigits=decimals)) | |||
| result = pc.round(self._pa_array, ndigits=decimals) | |||
| return type(self)(result.cast(self._pa_array.type)) | |||
mroeschke
reviewed
Nov 8, 2023
|
|
||
| def test_round(self, data): | ||
| if not data.dtype._is_numeric or data.dtype._is_boolean: | ||
| pytest.skip("Round is only valid for numeric non-boolean dtypes") |
There was a problem hiding this comment.
Can you test that would raise a TypeError instead?
mroeschke
reviewed
Nov 8, 2023
pandas/core/arrays/base.py
Outdated
| f"Cannot round {type(self)} dtype as it is non-numeric or boolean" | ||
| ) | ||
| return self._from_sequence( | ||
| [round(element) if not isna(element) else element for element in self], |
There was a problem hiding this comment.
self.isna or the self.dtype.na_value should probably be used to check for na instead of isna
|
this is ready for review again |
|
Let's do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This adds abstract round method in ExtensionOpsMixin to tell EA authors to implement round, and provides a round test.