Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EHN: read_spss stores the metadata in df.attrs #55472

Merged
merged 3 commits into from
Oct 10, 2023
Merged

EHN: read_spss stores the metadata in df.attrs #55472

merged 3 commits into from
Oct 10, 2023

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Oct 10, 2023 •
edited
Loading

mroeschke
mroeschke reviewed Oct 10, 2023
View reviewed changes
pandas/tests/io/test_spss.py Outdated
fname = datapath("io", "data", "spss", "labelled-num.sav")

df = pd.read_spss(fname)
assert df.attrs == {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make the dict a separate variable?

Copy link
Contributor Author

@yuanx749 yuanx749 Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done in the commit.

@mroeschke mroeschke added the IO Data IO issues that don't fit into a more specific label label Oct 10, 2023
@mroeschke mroeschke added this to the 2.2 milestone Oct 10, 2023
@mroeschke mroeschke merged commit b284101 into pandas-dev:main Oct 10, 2023
39 checks passed
@mroeschke
Copy link
Member

Thanks @yuanx749

@yuanx749 yuanx749 deleted the spss-meta branch October 11, 2023 02:05
@jbrockmendel jbrockmendel mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO Data IO issues that don't fit into a more specific label
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

read_spss doens't return the metadata
2 participants
@yuanx749 @mroeschke