Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: sort index with sliced MultiIndex #55473

Merged

Conversation

lukemanley
Copy link
Member

xref #55379

will open a separate PR for the targeted fix on 2.1.x

This test can be back-ported though.

@lukemanley lukemanley added Regression Functionality that used to work in a prior pandas version MultiIndex labels Oct 10, 2023
@mroeschke mroeschke modified the milestones: 2.2, 2.1.2 Oct 10, 2023
@mroeschke mroeschke merged commit f7b49d8 into pandas-dev:main Oct 10, 2023
39 checks passed
@mroeschke
Copy link
Member

Thanks @lukemanley

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 10, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f7b49d8eac88f9db365def1cd2babe03b84dadf4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55473: TST: sort index with sliced MultiIndex'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55473-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55473 on branch 2.1.x (TST: sort index with sliced MultiIndex)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

lukemanley added a commit to lukemanley/pandas that referenced this pull request Oct 11, 2023
mroeschke pushed a commit that referenced this pull request Nov 6, 2023
…ypeError) (#55819)

* Backport PR #55473: TST: sort index with sliced MultiIndex

* BUG: DatetimeIndex.diff raising TypeError (#55761)

* BUG: DatetimeIndex.diff raising TypeError

* add test and whatsnew

* typing

* use Index

(cherry picked from commit f04da3c)

* fix whatsnew
@lukemanley lukemanley deleted the test-sort-index-sliced-multiindex branch November 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants