Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/TST: Skip pyarrow csv tests where parsing fails #56015

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Nov 17, 2023

Follow up to #55943

Also reduces our CI timeout from 180 minutes to 90 since tests have been running a lot faster lately

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO CSV read_csv, to_csv CI Continuous Integration Arrow pyarrow functionality labels Nov 17, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 17, 2023
@jbrockmendel
Copy link
Member

Is this bc we think one of these is responsible for stalls?

@mroeschke
Copy link
Member Author

Is this bc we think one of these is responsible for stalls?

Yeah, I'm just being overly cautious based on apache/arrow#38676 and deeming any of these test that fail in pyarrow.csv.read_csv may stall due to thread/gil cleanup

@jbrockmendel jbrockmendel merged commit 089481f into pandas-dev:main Nov 17, 2023
40 checks passed
@jbrockmendel
Copy link
Member

thanks @mroeschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality CI Continuous Integration IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants