Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less C89, most const, static funcs #56254

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Nov 30, 2023

Will have to do this in a few passes for other files, but generally we:

  1. Are removing C89 style variable declarations at the top of functions
  2. Adding const qualifiers where we can
  3. Making more functions static that aren't intended to be linked outside of their translation unit

Point 1 helps with code readability, Point 2 can help with code safety and compiler optimization. Point 3 helps with code structure and makes functions "local" to their translaction unit instead of "global"

@mroeschke mroeschke added the Internals Related to non-user accessible pandas implementation label Nov 30, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 30, 2023
@mroeschke mroeschke merged commit 8e36cd1 into pandas-dev:main Nov 30, 2023
46 checks passed
@mroeschke
Copy link
Member

Thanks @WillAyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants