Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG fix for date_range 56134 #56831

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

jrmylow
Copy link
Contributor

@jrmylow jrmylow commented Jan 11, 2024

Edit, the first commit is incorrectly named - it fixes 56134 instead

@jrmylow
Copy link
Contributor Author

jrmylow commented Jan 11, 2024

pre-commit.ci autofix

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

doc/source/whatsnew/v2.3.0.rst Outdated Show resolved Hide resolved
pandas/core/arrays/datetimes.py Outdated Show resolved Hide resolved
@MarcoGorelli
Copy link
Member

Thanks for updating!

Edit, the first commit is incorrectly named - it fixes 56134 instead

it's fine, commits are squashed together anyway, the title of the PR is more important

@MarcoGorelli MarcoGorelli added this to the 3.0 milestone Jan 11, 2024
@MarcoGorelli MarcoGorelli added the Datetime Datetime data dtype label Jan 11, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best kind of bug fix - just, delete code, and the issue goes away

Looks good to me on green

Awesome stuff here @jrmylow !

@MarcoGorelli MarcoGorelli merged commit d5bd1f7 into pandas-dev:main Jan 11, 2024
54 checks passed
@jrmylow jrmylow deleted the 2024-01-11-fix_56134 branch January 30, 2024 07:13
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants