Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: autouse add_doctest_imports #57122

Merged
merged 2 commits into from
Jan 29, 2024
Merged

CI: autouse add_doctest_imports #57122

merged 2 commits into from
Jan 29, 2024

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Just trying this out to see impact to the CI

Ref: pytest-dev/pytest#11873
Effectively reverts #45667

@rhshadrach rhshadrach added Testing pandas testing functions or related to the test suite CI Continuous Integration labels Jan 29, 2024
@rhshadrach rhshadrach mentioned this pull request Jan 29, 2024
Open
@rhshadrach
Copy link
Member Author

@mroeschke - this gets doctests back to green, not noticing an appreciable slowdown.

mroeschke
mroeschke reviewed Jan 29, 2024
View reviewed changes
pandas/conftest.py
# ----------------------------------------------------------------
# Autouse fixtures
# ----------------------------------------------------------------
@pytest.fixture(autouse=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a reference to the pytest issue you opened? (Still hoping we don't have to use an autouse fixture one day)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mroeschke mroeschke added this to the 2.2.1 milestone Jan 29, 2024
@mroeschke mroeschke merged commit 3eea5fd into pandas-dev:main Jan 29, 2024
49 of 50 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 29, 2024
@rhshadrach @meeseeksmachine
Backport PR pandas-dev#57122: CI: autouse add_doctest_imports
630bb34
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 29, 2024
Merged
@rhshadrach rhshadrach deleted the ci_autouse_doctest_imports branch January 29, 2024 22:37
mroeschke pushed a commit that referenced this pull request Jan 29, 2024
@meeseeksmachine @rhshadrach
Backport PR #57122 on branch 2.2.x (CI: autouse add_doctest_imports) (#…
10b5873 
…57135)

Backport PR #57122: CI: autouse add_doctest_imports

Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@rhshadrach @pmhatre1
CI: autouse add_doctest_imports (pandas-dev#57122)
e6246f7 
* CI: autouse add_doctest_imports

* add ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rhshadrach @mroeschke