Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix _get_dst_hours for numpy 2.0 change #57144

Merged
merged 1 commit into from
Jan 30, 2024
Merged

CI: Fix _get_dst_hours for numpy 2.0 change #57144

merged 1 commit into from
Jan 30, 2024

Conversation

mroeschke
Copy link
Member

xref numpy/numpy#25570

I don't think we can make this annotation backwards compatible, so removing the annotation all together.

@mroeschke mroeschke added Timezones Timezone data dtype Compat pandas objects compatability with Numpy or Python functions labels Jan 30, 2024
@mroeschke mroeschke added this to the 2.2.1 milestone Jan 30, 2024
@mroeschke
Copy link
Member Author

Going to merge to get the CI back to green

@mroeschke mroeschke merged commit 9b95e45 into pandas-dev:main Jan 30, 2024
54 checks passed
@mroeschke mroeschke deleted the fix/npdev branch January 30, 2024 16:34
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 30, 2024
@mroeschke @meeseeksmachine
Backport PR pandas-dev#57144: CI: Fix _get_dst_hours for numpy 2.0 ch…
73bcef0 
…ange
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 30, 2024
Merged
mroeschke added a commit that referenced this pull request Jan 30, 2024
@meeseeksmachine @mroeschke
Backport PR #57144 on branch 2.2.x (CI: Fix _get_dst_hours for numpy …
27cea3a 
…2.0 change) (#57153)

Backport PR #57144: CI: Fix _get_dst_hours for numpy 2.0 change

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@lithomas1
Copy link
Member

Can you open up a followup issue? Thanks.

@mroeschke mroeschke mentioned this pull request Jan 30, 2024
Open
@mroeschke
Copy link
Member Author

Sure #57154

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
CI: Fix _get_dst_hours for numpy 2.0 change (pandas-dev#57144)
1689d99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions Timezones Timezone data dtype
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mroeschke @lithomas1