BUG: Updated _pprint_seq to use enumerate instead of next #57295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Bug
Output-Formatting
mroeschke
reviewed
Feb 7, 2024
| def test_nested_dataframe(self): | ||
| df1 = DataFrame({"level1": [["row1"], ["row2"]]}) | ||
| df2 = DataFrame({"level3": [{"level2": df1}]}) | ||
| df2.to_string() |
There was a problem hiding this comment.
Could you assert the result of this?
phofl
approved these changes
Feb 9, 2024
|
thx @cliffckerr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes an edge-case bug that has been around for almost 7 years.
To print a DataFrame, the function
_pprint_seq()constructs a string representation of an iterable object (calledseq) by creating an iterator over it, and truncating it iflen(seq) > max_seq_items.However, a pandas
DataFrameis an example of an object wherelen(seq)is not a valid way of checking the length of the iterator. Specifically,len(df)returns the number of rows, whileiter(df)iterates over the columns. When trying to print a DataFrame with more rows than columns, this raises aStopIteratorexception.This PR fixes this bug by explicitly iterating over the object, rather than assuming that
len(seq)is equal to the number of items in the object. The new testtest_nested_dataframe()raises an exception onmain, but passes on this branch.doc/source/whatsnew/v3.0.0.rst.