Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix argument for read_csv/read_table #5733

Merged
2 commits merged into from Jan 3, 2014

Conversation

nmichaud
Copy link
Contributor

Closes #5732

@jreback
Copy link
Contributor

jreback commented Dec 18, 2013

can you add some tests for this?

@nmichaud
Copy link
Contributor Author

One question I had about this - while use of the prefix argument now matches the documentation, this change is no longer backward compatible (if a user passed an arbitrary string and expected the columns to be named X1, X2,...)

@jreback
Copy link
Contributor

jreback commented Dec 18, 2013

@nmichaud prob just put a note in v0.14.txt to note that

@nmichaud
Copy link
Contributor Author

OK, added a test for the prefix argument.

@jreback
Copy link
Contributor

jreback commented Dec 19, 2013

@nmichaud actually just add a release notes entry in API for 0.13...and i'll throw it in...thanks

@ghost
Copy link

ghost commented Jan 1, 2014

@jreback, I'll add the release notes, you vetted this?

ghost pushed a commit that referenced this pull request Jan 3, 2014
Fix prefix argument for read_csv/read_table
@ghost ghost merged commit 7dbaff7 into pandas-dev:master Jan 3, 2014
@ghost
Copy link

ghost commented Jan 3, 2014

Will push release note directly.

@nmichaud nmichaud deleted the read_table_prefix_fix branch January 3, 2014 02:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_csv/read_table have a prefix argument which is not respected
2 participants