Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: DataFrame Interchange Protocol errors on Boolean columns #57758

Merged
merged 2 commits into from
Mar 27, 2024
Merged

BUG: DataFrame Interchange Protocol errors on Boolean columns #57758

merged 2 commits into from
Mar 27, 2024

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Mar 7, 2024 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

closes #55332

needs rebasing onto #57764

@MarcoGorelli MarcoGorelli added the Interchange Dataframe Interchange Protocol label Mar 7, 2024
@MarcoGorelli MarcoGorelli added this to the 2.2.2 milestone Mar 7, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 8, 2024 07:09
@MarcoGorelli MarcoGorelli force-pushed the interchange-boolean branch 2 times, most recently from dd56eff to 96b4429 Compare March 8, 2024 07:44
@MarcoGorelli MarcoGorelli marked this pull request as draft March 8, 2024 07:47
@MarcoGorelli MarcoGorelli marked this pull request as ready for review March 27, 2024 09:08
WillAyd
WillAyd approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@mroeschke mroeschke merged commit 9119aaf into pandas-dev:main Mar 27, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 27, 2024
@MarcoGorelli @meeseeksmachine
Backport PR pandas-dev#57758: BUG: DataFrame Interchange Protocol err…
f848f10 
…ors on Boolean columns
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 27, 2024
Merged
mroeschke pushed a commit that referenced this pull request Mar 27, 2024
@meeseeksmachine @MarcoGorelli
Backport PR #57758 on branch 2.2.x (BUG: DataFrame Interchange Protoc…
e1a7302 
…ol errors on Boolean columns) (#58036)

Backport PR #57758: BUG: DataFrame Interchange Protocol errors on Boolean columns

Co-authored-by: Marco Edward Gorelli <marcogorelli@protonmail.com>
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@MarcoGorelli @pmhatre1
BUG: DataFrame Interchange Protocol errors on Boolean columns (pandas…
1ddba4a 
…-dev#57758)

* BUG: DataFrame Interchange Protocol errors on Boolean columns [skip-ci]

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@mroeschke mroeschke mroeschke approved these changes

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
Interchange Dataframe Interchange Protocol
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame Interchange Protocol errors on Boolean columns
3 participants
@MarcoGorelli @mroeschke @WillAyd