Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Allow np.integer Series/Index to convert to RangeIndex #58016

Merged
merged 10 commits into from Apr 1, 2024

Conversation

mroeschke
Copy link
Member

Discovered in #57441

@mroeschke mroeschke added Performance Memory or execution speed performance Index Related to the Index class or subclasses labels Mar 26, 2024
@mroeschke mroeschke added this to the 3.0 milestone Mar 27, 2024
@mroeschke
Copy link
Member Author

Going to merge this one in. Can follow up if needed

@mroeschke mroeschke merged commit 5837042 into pandas-dev:main Apr 1, 2024
46 checks passed
@mroeschke mroeschke deleted the ref/range/ser_idx branch April 1, 2024 18:21
@phofl
Copy link
Member

phofl commented Apr 4, 2024

Not sure if this is the cuplrit but one of those has ugly side effects:

We now can end up with a range index from set_index, which doesn't play nicely with formats like orc. I think that this isn't great from a UX point of view if set_index produces a range index.

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…dev#58016)

* PERF: Allow np.integer Series/Index to convert to RangeIndex

* cast Series to array

* missing not

* Remove int32 casting in stata tests

* Add casting

* Specify int64

* don't overwrite sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Index Related to the Index class or subclasses Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants