Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500 #58043

Merged
merged 10 commits into from
Apr 16, 2024

Conversation

tehunter
Copy link
Contributor

@tehunter tehunter changed the title Bugfix slice selection BUG: DataFrame slice selection treated as hashable in Python 3.12 #57500 Mar 28, 2024
@tehunter
Copy link
Contributor Author

My commits are out of order, but I confirmed the unit test behaves correctly by backing out the bug fix and running my unit test on 3.12. As expected, it failed.

pandas/core/frame.py Outdated Show resolved Hide resolved
@mroeschke mroeschke added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex labels Apr 1, 2024
@tehunter tehunter requested a review from mroeschke April 15, 2024 13:19
@mroeschke mroeschke added this to the 3.0 milestone Apr 16, 2024
@mroeschke mroeschke merged commit 53bd1a8 into pandas-dev:main Apr 16, 2024
24 of 36 checks passed
@mroeschke
Copy link
Member

Thanks @tehunter

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…das-dev#57500 (pandas-dev#58043)

* Reorder slice and hashable in __getitem__

* Add unit test

* Fix test and formatting

* Update whatsnew

* Restore original flow ordering

* Move whatsnew entry to 3.0.0

* Move whatsnew entry to Indexing

* Update doc/source/whatsnew/v3.0.0.rst

---------

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Columns resulting from joining multiIndex dataFrame are incorrect in python 3.12.1
2 participants