DOC: update DatetimeTZDtype unit limitation #58213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Aloqeely
reviewed
Apr 10, 2024
pandas/core/dtypes/dtypes.py
Outdated
| @@ -699,7 +699,7 @@ class DatetimeTZDtype(PandasExtensionDtype): | |||
| ---------- | |||
| unit : str, default "ns" | |||
| The precision of the datetime data. Currently limited | |||
There was a problem hiding this comment.
I think we should consider deleting "Currently limited" since there are 4 possible options now.
There was a problem hiding this comment.
@Aloqeely thank you for your review.
How about
The precision of the datetime data. Only supports
``"s"``, ``"ms"``, ``"us"``, ``"ns"``.
as same as error message?
if unit not in ["s", "ms", "us", "ns"]:
raise ValueError("DatetimeTZDtype only supports s, ms, us, ns units")There was a problem hiding this comment.
Yes sure, Only supports and Valid options are both sound good to me.
|
/preview |
|
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/58213/ |
mroeschke
approved these changes
Apr 12, 2024
|
Thanks @yokomotod |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* doc: update DatetimeTZDtype unit limitation * fix description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.