Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the function to handle invalid boolean casting by returning … #58252

Closed
wants to merge 1 commit into from

Conversation

aabhinavg
Copy link

…None instead of raising a ValueError. This improves robustness and avoids unexpected interruptions in the flow of the program

  • closes 58159(Replace xxxx with the GitHub issue number)
  • Bug Fix (Modified the function to handle invalid)

…None instead of raising a ValueError. This improves robustness and avoids unexpected interruptions in the flow of the program
@Aloqeely
Copy link
Contributor

Aloqeely commented Apr 14, 2024

Thanks for the contribution! This doesn't address the problem, the returned value should be a boolean but you are returning None instead, and in the case where the value isn't a boolean then we want to raise a ValueError.

@aabhinavg
Copy link
Author

Thanks for the contribution! This doesn't address the problem, the returned value should be a boolean but you are returning None instead, and in the case where the value isn't a boolean then we want to raise a ValueError.

HI @Aloqeely Thank you for your valuable feedback. I will make the necessary changes to address the issues you mentioned. Before I submit an updated pull request, I want to ensure that the code passes all relevant test cases locally.

Could you please provide some guidance on how to run the test cases locally? Any specific commands or instructions you could share would be very helpful.

Thank you again for your assistance.

@Aloqeely
Copy link
Contributor

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants