-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: identity checking NA in map incorrect #58392
base: main
Are you sure you want to change the base?
BUG: identity checking NA in map incorrect #58392
Conversation
@mroeschke: Hello, hope you're doing well, would it be possible to merge this PR or should I propose another approach ? |
@mroeschke: for information I put this PR in Draft because I try to avoid a cast in object before calling |
pre-commit.ci autofix |
For information, the idea in this new PR version is to be able to take into account into
That's why I add a |
for more information, see https://pre-commit.ci
…ps://github.com/droussea2001/pandas into BUG-57390/Identity-checking-NA-in-map-incorrect
@WillAyd : Hello Will, I would have a question: the check "Docstring validation, typing, and other manual pre-commit hooks" is in the state "cancelled" in the CI just after the following line:
I don't see any error (I try to rebuild it locally from scratch) and the other checks seems to be ok. Would you have an idea about what causing this problem ? |
I agree that looks strange - just restarted the job. Let's see what happens |
The error is clearer now, I will investigate. :-) Thanks a lot ! |
…checking-NA-in-map-incorrect
…checking-NA-in-map-incorrect
…checking-NA-in-map-incorrect
…ps://github.com/droussea2001/pandas into BUG-57390/Identity-checking-NA-in-map-incorrect
…checking-NA-in-map-incorrect
map
is incorrect #57390doc/source/whatsnew/v3.0.0.rst
file if fixing a bug or adding a new feature.In bug #57390 Identity checking NA in map is incorrect because pd.NA are coerced to np.nan when evaluating a UDF.
This PR proposes to correct this problem in:
A) Avoiding cast in
object
formap
inputB) Avoiding cast in
object
formap
outputThat's why
test_map
andtest_map_na_action_ignore
were modified in this way (we expect in this modified tests to keeppd.NA
after amap
)