Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend eval test of standard functions to cover python engine. #58393

Merged
merged 1 commit into from Apr 24, 2024

Conversation

domsmrz
Copy link
Contributor

@domsmrz domsmrz commented Apr 23, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number) (no issue created)
  • Tests added and passed if fixing a bug or adding a new feature (not applicable)
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions. (not applicable)
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature. (not applicable)

IIUC the standard functions are (now?) supported in both engines and we can have tests for that.

@domsmrz domsmrz changed the title Extend eval test of standard functions to cover pandas engine. Extend eval test of standard functions to cover python engine. Apr 23, 2024
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite expressions pd.eval, query labels Apr 23, 2024
@mroeschke
Copy link
Member

Thanks for the PR, is there an associated issue?

@domsmrz
Copy link
Contributor Author

domsmrz commented Apr 24, 2024

Thanks for the PR, is there an associated issue?

None that I'm aware of. I sort of randomly noticed this when I was trying to understand how does eval work. I was thinking about submitting an issue first but given that this is purely test change it doesn't feel like a bug nor a feature. Anyway, given the nature of the change and the very small size I figured that the easiest way forward would be just submit the PR.

Let me know if I should do anything else (or that we just don't want to merge this for any reason -- if that is the case).

@mroeschke mroeschke added this to the 3.0 milestone Apr 24, 2024
@mroeschke mroeschke merged commit c342e9f into pandas-dev:main Apr 24, 2024
51 of 52 checks passed
@mroeschke
Copy link
Member

Thanks @domsmrz

@domsmrz domsmrz deleted the eval_unary_tests branch April 24, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expressions pd.eval, query Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants