Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #58658 on branch 2.2.x (CI/TST: Don't xfail test_api_read_sql_duplicate_columns for pyarrow=16 and sqlite) #58660

Merged
merged 1 commit into from
May 9, 2024
Merged

Backport PR #58658 on branch 2.2.x (CI/TST: Don't xfail test_api_read_sql_duplicate_columns for pyarrow=16 and sqlite) #58660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2320,9 +2320,15 @@ def test_api_escaped_table_name(conn, request):
def test_api_read_sql_duplicate_columns(conn, request):
# GH#53117
if "adbc" in conn:
request.node.add_marker(
pytest.mark.xfail(reason="pyarrow->pandas throws ValueError", strict=True)
)
pa = pytest.importorskip("pyarrow")
if not (
Version(pa.__version__) >= Version("16.0") and conn == "sqlite_adbc_conn"
):
request.node.add_marker(
pytest.mark.xfail(
reason="pyarrow->pandas throws ValueError", strict=True
)
)
conn = request.getfixturevalue(conn)
if sql.has_table("test_table", conn):
with sql.SQLDatabase(conn, need_transaction=True) as pandasSQL:
Expand Down