-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Removes inplace
option for `pandas.core.resample.Resampler.i…
#58847
base: main
Are you sure you want to change the base?
feat!: Removes inplace
option for `pandas.core.resample.Resampler.i…
#58847
Conversation
…nterpolate`. Fixes / cleans up related test cases.
…. Adds breaking API change description to whatsnew.
@MarcoGorelli somehow it did not auto-assign the reviewers. But in any case, here we are :) |
Do these need to be deprecated first? You can use the |
I don't know what the exact policy is. But as far as I understand the deprecation tells the user that a certain future change will change the API. This does not apply here, as the inplace-functionality is already broken. We would need to add the deprecation to pandas 2 to inform users about the upcoming change, and to ease migration. But I guess this would need a separate PR that targets the next 2.x release. |
Thanks @Aloqeely - in general, yes, this would require a deprecation. However, here, the change is going to breaking anyway (in order to fix a historic |
…e` without prior resample.
…true-58690-remove-inplace-option
…true-58690-remove-inplace-option
…true-58690-remove-inplace-option
…true-58690-remove-inplace-option
@mroeschke can we merge this? 😄 |
…true-58690-remove-inplace-option
@@ -146,7 +146,7 @@ def test_interpolate_downcast_reference_triggers_copy(): | |||
|
|||
msg = "Can not interpolate with method=pad" | |||
with pytest.raises(ValueError, match=msg): | |||
df.interpolate(method="pad", inplace=True, downcast="infer") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that a lot of interpolate usages are still modified in the PR. Only tests that used to call.resample(...).interpolate(interpolate=)
should have been changed
…nterpolate`. Fixes / cleans up related test cases.
main
, usingresample().interpolate(inplace=True)
raises an exception #58690 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.