-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: numba apply supports positional arguments passed as **kwargs #58995
Open
auderson
wants to merge
18
commits into
pandas-dev:main
Choose a base branch
from
auderson:enh_numba_apply_support_kwargs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ENH: numba apply supports positional arguments passed as **kwargs #58995
auderson
wants to merge
18
commits into
pandas-dev:main
from
auderson:enh_numba_apply_support_kwargs
+110
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8168d9b
to
c211119
Compare
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.@lithomas1
This is a followup PR that enhances
prepare_function_arguments
introduced in #58767.prepare_function_arguments
helps to move**kwargs
to*args
where possible usinginspect.Signature
. And now it's also more reasonable to move kwargs check fromget_jit_arguments
toprepare_function_arguments
.ref: #58767 (comment)
There are several places where the usage of
get_jit_arguments
is updated andprepare_function_arguments
is added :groupby.agg
,groupby.transform
,rolling.apply
anddf.apply
.