Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/TST: #6175, specializing assert_ (WIP) #6197

Closed
wants to merge 2 commits into from
Closed

CLN/TST: #6175, specializing assert_ (WIP) #6197

wants to merge 2 commits into from

Conversation

bwignall
Copy link
Contributor

Helping with the specialization request. Work-in-progress. Updated tests pass locally.

@ghost
Copy link

ghost commented Jan 31, 2014

Looks good. I'd merge on green but will wait until 0.13.1 is released, out of caution.
Please have a look at guidelines on commit subjects in https://github.com/pydata/pandas/blob/master/CONTRIBUTING.md. If you're comfortable with git,
you may amend, if not leave them as is and we'll take care of it.

If you wish to do more, I suggest you open a seperate PR with more work.
Keeping PRs small makes it easier for us to review and merge with confidence.

Thanks for contributing.

@bwignall
Copy link
Contributor Author

Thanks for your comment, y-p. My apologies on the mistake; I am still learning my way around git. I will open another PR with more on this topic shortly, hopefully that goes more smoothly.

@ghost
Copy link

ghost commented Jan 31, 2014

On the contrary, if that's the case you've done very well.

@ghost
Copy link

ghost commented Feb 4, 2014

#6198 superceded this.

@bwignall, it's good practice to always start a new PR by branching against the current
git master. If you include the commits from one PR in another (sometimes one PR depends
on another) please explicitly state that you've done so and why, or close the superceded
one if it has been.

Git takes some getting used to, don't beat youself up. Thanks again for contributing.

@ghost ghost closed this Feb 4, 2014
@bwignall
Copy link
Contributor Author

bwignall commented Feb 5, 2014

@y-p,

My apologies (again) for the elementary mistakes. I appreciate your patience and your suggestions.

I am happy to help. I will endeavor to do so more efficiently in the future.

@bwignall bwignall deleted the assert_6175 branch February 18, 2014 03:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant