Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Series.iteritems should be lazy #6761

Merged
merged 1 commit into from
Apr 1, 2014

Conversation

TomAugspurger
Copy link
Contributor

Closes #6760

@jreback
Copy link
Contributor

jreback commented Apr 1, 2014

this seems fine
ok when green

TomAugspurger pushed a commit that referenced this pull request Apr 1, 2014
BUG: Series.iteritems should be lazy
@TomAugspurger TomAugspurger merged commit 772b13a into pandas-dev:master Apr 1, 2014
@TomAugspurger TomAugspurger deleted the lazy-iteritems branch April 1, 2014 20:36
@immerrr
Copy link
Contributor

immerrr commented Apr 2, 2014

A minor nitpick: the test won't catch lists in py3, because getslice is deprecated since py2.6 and is removed in py3:

In [3]: sys.version
Out[3]: '3.3.3 |Continuum Analytics, Inc.| (default, Nov 25 2013, 17:28:04) \n[GCC 4.1.2 20080704 (Red Hat 4.1.2-54)]'

In [4]: list()
Out[4]: []

In [5]: _4.__getslice__
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-5-ff32cb569e0e> in <module>()
----> 1 _4.__getslice__

AttributeError: 'list' object has no attribute '__getslice__'

This is probably not an issue within this PR, since it was fixing a py2-specific inconsistency, but worth keeping an eye on.

@TomAugspurger TomAugspurger restored the lazy-iteritems branch April 2, 2014 13:11
@TomAugspurger
Copy link
Contributor Author

Thanks. I didn't realize it was deprecated. I'll switch to checking for reverse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Series.iteritems() isn't lazy
3 participants