Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix isnull for 0d object arrays #7176

Merged
merged 1 commit into from
May 20, 2014

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 19, 2014

If this looks good, it would be nice to get it in 0.14, too.

@jreback
Copy link
Contributor

jreback commented May 19, 2014

pls test for several dtypes (float64/int64) as well

and use assertTrue/False rather than bare assert

@jreback
Copy link
Contributor

jreback commented May 19, 2014

need a release note (ref the pr number)

@jreback jreback added the Bug label May 19, 2014
@jreback jreback added this to the 0.14.0 milestone May 19, 2014
shoyer added a commit to shoyer/xarray that referenced this pull request May 19, 2014
This is a work-around for this upstream issue:
pandas-dev/pandas#7176
@shoyer
Copy link
Member Author

shoyer commented May 19, 2014

@jreback New commit up.

@jreback
Copy link
Contributor

jreback commented May 19, 2014

looks good
can u squash to 1 commit pls

@shoyer
Copy link
Member Author

shoyer commented May 19, 2014

Squashed

jreback added a commit that referenced this pull request May 20, 2014
BUG: fix isnull for 0d object arrays
@jreback jreback merged commit 2bdfcff into pandas-dev:master May 20, 2014
@jreback
Copy link
Contributor

jreback commented May 20, 2014

thanks!

@shoyer shoyer deleted the isnull-0d-object-array branch May 20, 2014 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants