CI: Drop numpy 1.6 support #7954
Conversation
|
well that was cathartic |
|
fyi, your 2.6/2.7_locale build are prob taking forever as they have to compie numpy (until the wheel is there) |
|
yeah i know .. there's some fails too |
|
i think we might need to require 1.7.1, there's an issue with type coercion in ufuncs in 1.7.0 not totally sure what the issue is taking a look now |
|
arg nope 1.7.1 still fails |
| @@ -658,11 +658,10 @@ def test_constructor_dtype_datetime64(self): | |||
| expected = Series(values2, dates) | |||
|
|
|||
| # numpy < 1.7 is very odd about astyping | |||
|
ok wheels are up for 1.7.0/1.7.1 on both 2.6 and 2.7_LOCALE enjoy! |
|
I'm going to close this until i make some more progress |
|
whoops wrong pr |
|
This will pass but there's a weird bug where with tm.assertRaises(ValueError):
o.item()will fail but self.assertRaises(ValueError, o.item)will pass there might be a weird py26 bug in this decorator ... let me see if i can't dig around and fix it |
|
@jreback @jorisvandenbossche Any comments? The assert raises issue only shows up on Travis, even when I use the exact same deps. |
|
yeh I think their might be something in the decorator I always use:
|
| from pandas.version import version as __version__ | ||
| from pandas.info import __doc__ | ||
|
|
||
|
|
||
| if LooseVersion(_np_version) < '1.7.0': |
There was a problem hiding this comment.
not tested anywhere I assume (as we are not running builds like this), but give a test manually
There was a problem hiding this comment.
tested this
not totally sure how you'd even get past the setup.py but this will raise if somehow you do
|
need to update |
|
Cool. Will do. You actually don't need a lambda in those cases because the function is already a no argument callable. A bit easier to read IMO |
|
@jreback good to go? |
|
i'll squash if you watn |
| .. warning:: | ||
|
|
||
| pandas will no longer support compatibility with NumPy versions < 1.7.0. If | ||
| you want to use the latest versions of pandas, please upgrade to NumPy >= |
There was a problem hiding this comment.
add this to highlites too (I know its sort of duplicated but that's ok)
There was a problem hiding this comment.
i just moved it up to right above the "Highlights include"
|
version is also mentioned in the readme |
|
minor comments (I would squash). ok otherwise |
|
alright if this next build passes going to merge @jorisvandenbossche thanks for the heads up about the readme |
|
ok sure |
|
this is passing on my fork, travis is going to take forever to get to this i guess can merge tomorrow |
|
if passing then ok to merge |
closes #7711