BUG: Resample across multiple days #8941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hkleynhans I think test_resample.py is a better place to put the test (https://github.com/hkleynhans/pandas/blob/fix/8683_resample_value_error/pandas/tseries/tests/test_resample.py) |
|
|
||
| foffset = (first.value - start_day_nanos) % offset.nanos | ||
| loffset = (last.value - last_day_nanos) % offset.nanos | ||
|
|
||
| loffset = (last.value - start_day_nanos) % offset.nanos |
There was a problem hiding this comment.
very small nitpick, but can you keep the blank line after this to keep the visual blocks
hkleynhans
force-pushed
the
fix/8683_resample_value_error
branch
from
e6531c8
to
2b77f51
Compare
Fixes an issue where resampling over multiple days causes a ValueError when a number of days between the normalized first and normalized last days is not a multiple of the frequency. Added test TestResample.test_resample_anchored_multiday Closes pandas-dev#8683
hkleynhans
force-pushed
the
fix/8683_resample_value_error
branch
from
2b77f51
to
5a2b19b
Compare
|
Thanks for the feedback. The issues have been addressed. |
|
@jreback can you have a look at this? (or is there someone with great knowledge of the resample code?) But the change seems logic, and the tests pass |
|
will have a look |
|
looks good. @jorisvandenbossche merge on green. |
|
@hkleynhans Thanks a lot! It was nice debugging |
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 30, 2014
BUG: Resample across multiple days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where resampling over multiple days causes a ValueError
when a number of days between the normalized first and normalized last
days is not a multiple of the frequency.
Added test TestSeries.test_resample
Closes #8683