FIX: Fix encoding to allow StataReader to read urls #9245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix is not finished - mostly using it to document the issue. The StringIO is returning unicode while unpack expects bytes (or string on Python 2). This simply encodes the unicode to a new StringIO object, and is very ugly. |
bashtage
force-pushed
the
stata-url
branch
2 times, most recently
from
1ba5898
to
bcef1e9
Compare
bashtage
force-pushed
the
stata-url
branch
3 times, most recently
from
7056f0a
to
b1f0fb7
Compare
|
One timed out, the others all passed, so it seems ready, barring other issues in the method I used. |
| @@ -105,7 +105,7 @@ Bug Fixes | |||
| - Bug in left ``join`` on multi-index with ``sort=True`` or null values (:issue:`9210`). | |||
|
|
|||
|
|
|||
|
|
|||
| - Fixed character encoding bug in `read_stata` and `StataReader` when loading data from a URL (:issue:`9231`). | |||
There was a problem hiding this comment.
make these double back ticks on both sides of the word
|
minor comment, I restarted the stalled job |
|
@jreback Looks good. Let me know if you need me to rebase. |
Fix encoding so that StataReader can correctly read URLs closes pandas-dev#9231
jreback
added a commit
that referenced
this pull request
Jan 16, 2015
FIX: Fix encoding to allow StataReader to read urls
|
@bashtage thanks! |
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 3, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
7 tasks
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 3, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 3, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 5, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 5, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 6, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 6, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 7, 2022
Fixes pandas-dev#48700 Regressed in pandas-dev#9245 Regressed in 2f0ada3
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 10, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 11, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 11, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 11, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 11, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 11, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 14, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
akx
added a commit
to akx/pandas
that referenced
this pull request
Oct 15, 2022
Fixes pandas-dev#48700 Refs pandas-dev#9245 Refs pandas-dev#37639 Regressed in 6d1541e
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix encoding so that StataReader can correctly read URLs
closes #9231