Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating the trellis rplot module (GH3445) #9357

Merged
merged 2 commits into from
Mar 5, 2015

Conversation

jorisvandenbossche
Copy link
Member

Closes #3445


Start for #3445. Then the current examples should get a seaborn or ggplot alternative.

Questions:

  • explicitely refer to seaborn and ggplot as alternatives? (as there may be other packages that could feel neglected that way?)
  • I now raise the warning on import of the module (import pandas.tools.rplot as rplot). The only thing is that the warning will be raised in the tests this way

@TomAugspurger
Copy link
Contributor

@TomAugspurger Did you already have some examples of how to do it in seaborn? I vaguely can remember you posted it once in an issue?

@jorisvandenbossche I redid all the examples using seaborn. A quick search didn't turn it up, but I'll dig for it later.

@tacaswell
Copy link
Contributor

There are ways to both suppress and check for warnings in the tests, we have a couple of examples of it in mpl's test suite.

@shoyer
Copy link
Member

shoyer commented Jan 26, 2015

I'm not sure ggplot is ready for prime time. I would probably only recommend Seaborn at this point.

@jorisvandenbossche
Copy link
Member Author

@shoyer yes, I could agree, as I noticed while trying to convert some of the examples to gpplot this was not easy (some of the functionality of rplot is not yet included in ggplot). I will update the PR

@jankatins
Copy link
Contributor

I agree too: ggplot currently doesn't handle categorical data very well if faceting is used (actually that was my motivation for working on categorical data in pandas :-) ).

@jorisvandenbossche
Copy link
Member Author

OK, I will remove ggplot for now from the explanation, and if @TomAugspurger finds his seaborn examples, we can add that. But @JanSchulz, if you want to add some ggplot examples when there is some progress, certainly do!

@jreback
Copy link
Contributor

jreback commented Mar 3, 2015

@jorisvandenbossche @TomAugspurger let's do this for 0.16.0 (pls add a refernce in #6581) as well

@jorisvandenbossche
Copy link
Member Author

I made some examples of how to do it with seaborn, for each example in de rplot docs now: http://nbviewer.ipython.org/gist/jorisvandenbossche/103876bff4a5f42c9933#

@TomAugspurger Can you have a looks if this looks good? Or if there are better ways? (only for the last example (4 variables) I did not found a fully equivalent seaborn-way of doing it)

@jreback For the actual PR, I assume adding seaborn as a doc dependency is not that handy, so I better include all the figures as images?

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Mar 4, 2015 via email

@jorisvandenbossche
Copy link
Member Author

I fully agree about that mess :-)

The rest is looking OK?


ScaleRandomColour(column)
g = sns.FacetGrid(tips_data, row="sex", col="smoker", hue="day")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might add hue_kws={"marker": ["^", "v", "s", "*"]} if you like the symbols.... or not :).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the different symbols then additional to the different colors? Or in place of?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The symbols are matched with colors 1 to 1. See the Seaborn docs on plotting on data aware grids for details.

On Wed, Mar 4, 2015 at 11:23 AM, Joris Van den Bossche
notifications@github.com wrote:

  • ScaleRandomColour(column)
  • g = sns.FacetGrid(tips_data, row="sex", col="smoker", hue="day")
    Are the different symbols then additional to the different colors? Or in place of?

Reply to this email directly or view it on GitHub:
https://github.com/pydata/pandas/pull/9357/files#r25804584

@shoyer
Copy link
Member

shoyer commented Mar 4, 2015

This looks great to me!

@jreback
Copy link
Contributor

jreback commented Mar 4, 2015

@jorisvandenbossche I think just need a release note in the deprecations sections

@jorisvandenbossche
Copy link
Member Author

@jreback ah yes!

jorisvandenbossche added a commit that referenced this pull request Mar 5, 2015
Deprecating the trellis rplot module (GH3445)
@jorisvandenbossche jorisvandenbossche merged commit f71d811 into pandas-dev:master Mar 5, 2015
@jorisvandenbossche jorisvandenbossche deleted the rplot branch March 5, 2015 08:55
jreback pushed a commit that referenced this pull request Aug 2, 2016
xref #9357.    Title is self-
explanatory.

Author: gfyoung <gfyoung17@gmail.com>

Closes #13855 from gfyoung/trellis-plot-remove and squashes the following commits:

5427086 [gfyoung] CLN: Removed trellis rplot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecating the trellis rplot module
6 participants