project name in navbar if no logo given #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just added some tests for this. If they're happy I'll merge this in because I think this is pretty non-controversial (arguably is fixing a 🐛). Please let me know if you disagree and I'm happy to hold off! |
|
Thanks for the fix! That's certainly fine to merge such non-controversial fixes (and especially if they come with a test ;-)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings this theme in line with common convention in other Sphinx themes to include the project name in the navbar if no
html_logois given.Current if no
html_logois present then the navbar sizing gets a little bit weird and there's a big whitespace to the left, so I think this is a better default behavior