Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: made scikit-learn as mandatory dependency #76

Merged
merged 1 commit into from
Sep 5, 2016
Merged

CLN: made scikit-learn as mandatory dependency #76

merged 1 commit into from
Sep 5, 2016

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Sep 3, 2016

made scilit-learn as mandatory dependency (added requirements.txt).

@sinhrks sinhrks added this to the 0.4.0 milestone Sep 3, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.958% when pulling cede593 on sinhrks:sklearn_dep into 0cf0f41 on pandas-ml:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 94.958% when pulling cede593 on sinhrks:sklearn_dep into 0cf0f41 on pandas-ml:master.

@coveralls
Copy link

coveralls commented Sep 3, 2016 •
edited

Coverage Status

Coverage increased (+0.2%) to 94.958% when pulling cede593 on sinhrks:sklearn_dep into 0cf0f41 on pandas-ml:master.

@coveralls
Copy link

coveralls commented Sep 4, 2016 •
edited

Coverage Status

Coverage increased (+0.2%) to 94.977% when pulling 40d6390 on sinhrks:sklearn_dep into 4fae348 on pandas-ml:master.

@sinhrks
Copy link
Member Author

sinhrks commented Sep 5, 2016

@scls19fr is it ok for you?

@scls19fr
Copy link
Contributor

scls19fr commented Sep 5, 2016

@sinhrks it looks good to me!

@sinhrks sinhrks merged commit 92a0900 into pandas-ml:master Sep 5, 2016
@sinhrks sinhrks deleted the sklearn_dep branch September 5, 2016 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sinhrks @coveralls @scls19fr