Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added test script for packaging #960

Closed
wants to merge 1 commit into from
Closed

[WIP] Added test script for packaging #960

wants to merge 1 commit into from

Conversation

jchodera
Copy link
Member

Just beginning to add some automation for testing packaging. Not ready to merge yet.

@peastman
Copy link
Member

What's the status of this PR? Has it been abandoned, or do you still plan to come back to it?

@jchodera
Copy link
Member Author

I'm happy to pick it up again if you think it would be useful to automate testing of the binary package. If not, we can drop it.

@peastman
Copy link
Member

I'm not entirely clear on what the intended feature is. When would this script be run, and on what computer? Will there be similar tests for other OSes?

@jchodera
Copy link
Member Author

The original idea was that this would be run by the Jenkins build system immediately after building the binary package, so that we didn't have to have you open it up and test it manually.

@peastman
Copy link
Member

If you want to have it do that, I have no objection. It won't eliminate the need for manual testing, though. There are a lot of situations where a binary works on the machine it was built on, but fails on other machines (especially if they have a different OS version).

So it's up to you whether you want to finish this or just close it.

@swails
Copy link
Contributor

swails commented Apr 1, 2020

I'm not sure why this branch triggered a build. But the machine it's running on crashed.

@peastman
Copy link
Member

peastman commented Dec 3, 2020

Closing abandoned PRs.

@peastman peastman closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants