New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpine texlive #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been thinking about how to structure this. I think this would be reasonable if we created pandoc
user on docker hub
-
pandoc/alpine
repository (is currentlytarleb/alpine-pandoc
).- Add
master
tag. Oredge
? I'm confused byedge
vsmaster
in theMakefile
. - Add
2.5
(stable) tag. - Push
:latest
as2.5
. - Maybe moving this into
alpine/base
was bad or misleading? I likeFROM pandoc/alpine:tag
better thanFROM pandoc/alpine-base:tag
for people who just wantpandoc
. Easy to fix / revert.
- Add
-
Add
pandoc/alpine-texlive
repository which builds on top of (1).
I've been thinking about how to deal with automation here. Some brief reading online seems to indicate that builds on docker hub can run for a maximum of two hours. Locally (with a parallel build), the base image that actually builds pandoc
took ~35 minutes. So on their (serial, I believe) builds we will probably not timeout.
Since the code in the docker files are not really going to be changing that much, what we can do is trigger from the web and just setup a cron build job with Travis CI or something. Perhaps triggering a master
(edge
?) build maybe once a month?
The :latest
and official release versions would basically just get built once and stashed, and the :master
tag would be a rolling tag. Does this make sense?
alpine/texlive/Dockerfile
Outdated
# 2. Install `libsrvg`, pandoc uses `rsvg-convert` for working with svg images. | ||
# | ||
# NOTE: to maintainers, please keep this listing alphabetical. | ||
RUN apk --no-cache add librsvg \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgm Is rsvg-convert
the tool you were talking about? I found this patch, but it's not mentioned explicitly in the MANUAL so I'm not really sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start.
I'm not sure about the -j
though, please you open a separate PR for that.
Maybe we could do both. It seems like good style to provide obvious choices for users, so people don't have to understand the naming scheme first. We could tag the |
I accidentally edited your comment instead of writing a proper reply (yes, I need some coffee). See above. |
Me too, tbh ;) I was under the impression that
Good idea.
Let's try it then 👍 |
Results gathered. No
I agree with the sentiment, But I really don't actually care that much. Just trying to reduce workload.
I know little to nothing of the common practices.
First attempt on my fork does not bode well. Locally I was able to build |
status update: docker hub build took almost 2 hours. Travis CI is potentially a good fit, but the base alpine image runs dangerously close to the 50 minute time limit. I tried to
It's kind of strange that it takes almost double the time to build on travis than it does locally, this desktop is not that powerful. I will do a little more research / am waiting until tomorrow to see what happens with the cron build for next Will open a PR soon 🙂 |
Not quite ready for merge yet, see review.
Fixes #1 .
Warning: currently this produces a 2.25 GB image.
ncdu
reveals that this is mostly fonts (specifically fromtexmf-dist-most
), so maybe we can choose to be more selective with that. But there seem to be a lot of hidden dependencies with latex and fonts that are actually required.I can retry with less stuff installed, but I need guidance on how to actually test the full latex side of pandoc.