-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with new beacons #448
Comments
Any reason why?
Those should all be fixed now: OgelGames/beacon@a3cc21e
Don't know why that is happening...
I
That should also be fixed by the above commit, which makes it possible to rotation the beacon with a screwdriver before activating the beacon.
Again, should be fixed by the above commit.
Probably caused by the corrective name change from purple to violet.
Yeah, I probably should change that...
I'm not sure if I understand this one...
That's an unfortunate side effect, which I don't know of a solution for... Edit: Also see this issue: OgelGames/beacon#1 |
that was from me: place beacon against wall / ceiling (have not noticed with upward pointing beacons) |
size of the beam would make sense. |
That would be something wrong with the cleanup lbm, but that might be fixed now.
Fixed: OgelGames/beacon@a2d4d2d |
Added one more item to above list: In fancy vendor, spinning textured model only draws other side. Of course for things that are issues that must be fixed in code it is probably better to open separate issue and link here, ^ that list was mostly to collect all stuff together for easy evaluation and easily dropping things that do not require any real actions. |
Because original green beacon range was 20m, so it would not break fly in areas where beacons have already been installed. |
Before change one could see range of beacon, now you cant see range for next beacon before you either fall or reach it. edit. seems like I grabbed reply to wrong question / issue. would be still nice if there was some solution so any ideas anyone? |
no real solution there except try it on and get used to it. Up until now there were many places where you couldn't see beacons at all and glider ensured that it mostly worked out fine. With many beacons being close together any HUD-radar solution would just crowd the screen to uselessness. /beacons_effects seems to cover it sufficiently. Maybe add coordinates there in the extended info option. |
I've just tested 6b1486f and these are my opinions:
Good job, I like the remake a lot :) Edit: for UX sake, it may be good to require a beacon base to be present for effect as it has been. |
I'm not sure what the issue is here, all the old green beacons will have been converted to a range of 30, and new beacons can be upgraded if 20 is needed.
Very good point 👍
I'm fine with that if the beacons are added to the replacer blacklist, because that's the only reason I changed it, and I much prefer automatic beam activation.
I could add that, but I'd rather not because then some players might not realize that the beacons have changed.
Is it possible to only blacklist it for the multi-node modes, and still be able to use it in single node mode?
Interesting...
It was working fine for me, though the beacon does lack a rotation indicator (all sides are the same).
That's the constructor's problem, not beacons, and the beam isn't really supposed to be diggable anyway 😄
I will be fixing that 😉
That's because the code for the old fly effect is still active in the
I will probably change it to that, it makes the beam more important. |
they should not notice the change by the beacon failing them |
Yes by maintaining a second list and offering registration methods. |
Oh, i completely forgot that... i'll remove that part if thats ok...? |
Yes, should be fine to remove it... |
That I noticed too but was sure that customization will be removed very soon because it was planned during mod building. That's why I added this here because it might make some current building sites harder to fix and falling is not really nice way to introduce upgrades.
I bet there's enough things already that will reveal upgrades like placing beacon to wall instead of ground is actually very big and noticeable change, maybe not immediately but will be noticed by players who regularly use beacons. Also players talk a lot about beacons in chat because they did notice updates and because it is big change. |
I've made a few more changes to fix most of the issues. (also see original post above)
It has been changed to the original action of activating after placement if there is enough room, and a check has been added to prevent activation if placed by a
I have added a setting ( |
I have moved the two remaining issues here: OgelGames/beacon#3 For any new issues, please open an issue in the mod repository. |
Here come copy paste from chat
Related #430 New active Beacon area effects
should probably fix range to 20 for upgraded beacons
Solution?
chat spamming "Not enough room to place beacon pointing in -X direction!" :p
is there some specific reason why I cannot place beacon without beam..?
I have chat full of beacon message spam because beacons cant be placed with deployer
Solution: No action needed, deployer actually works exactly as it should. Just different with old beacon because beam always pointed upwards.
oh god, now I get formcpec spam without touching anything
I got formspec every second while just walking around. But apparently it can be stopped by opening chat.
Solution: Caused by some (owned) device hitting beacon and triggering formspec. Most probably deployer or digtron. Probably no action needed, very rare thing.
beam hitbox seems to be a bit too small, that one was not fixed?
I dont have problems seeing hitbox but hitbox is now too small while with old beacons it was too large.
Solution: Increased size of hitbox (selection box).
was there way to place beacon to wall while keeping beam pointing upwards?
yes, currently placing with replacer places upwards
deactivate turn off beam and effect
Solution: Beacons (including beam) can now be deactivated, afterwards beacon can rotated with a screwdriver to change direction.
should be able to place just beacon box node without space for beam
allow placing beacons when beam cant fit, now probably need to place
using jumpdrive?
Solution: Beacons can now be placed anywhere, but can only activate if there is enough room.
digtron got really confused about beacons, maybe it had old or something but seems it
attempted building violet beacon while it only had green in storage
but did not crash at least, just skipped building
Solution: No solution known, but most likely caused by the corrective name change from purple to violet.
does range 50 mean 25+ and 25-?
range 50 should be same as radius 50
so +/- 50 from beacon node
just not same radius that other mods define. that would be good to fix so that it follows
more common definition
range is actually value - half node from outer edge of beacon box. basically range from center of beacon.
Solution: Changed 'Range' to 'Effect Radius' in formspec.
hmm, some beams are missing here for some reason :/
beams from box, then nothing then beams again
why do some disapear anyway when placed by box
Solution: Most likely something wrong in the cleanup LBM, will need to investigate further.
now when I think about it this beacon update with colors / selectable effects causes
one more problem, you cannot trust any of beacons you see to have fly effect and also cant tell effect range from distance.
Solution: No action needed, see comment below. (Problems with new beacons #448 (comment))
In fancy vendor, spinning textured model [of beam nodes] only draws other side.
Also could look a lot better to have extruded model in vendor like most other items.
Solution: Possibly something to do with the beam node models, will need to investigate further.
Cannot build to beacons with sneak rmb
Should be possible to do this.
Solution: Allow skipping formspec when sneak building.
Ping @OgelGames you could probably best answer some of these right away and then we see if there's something left to fix.
The text was updated successfully, but these errors were encountered: