Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of biofuel input items #450

Closed
SwissalpS opened this issue Feb 20, 2020 · 8 comments · Fixed by pandorabox-io/pandorabox-mods#494
Closed

List of biofuel input items #450

SwissalpS opened this issue Feb 20, 2020 · 8 comments · Fixed by pandorabox-io/pandorabox-mods#494
Labels
enhancement New feature or request Fixed Issue has been fixed/resolved but is waiting for something or needs testing

Comments

@SwissalpS
Copy link
Contributor

SwissalpS commented Feb 20, 2020

Suggestions for materials to be added as biofuel-able

  • glue
  • sugar
  • agave (if not already)
  • rye, oat and barly seeds
  • rice?
  • since papyrus works, why not minegeld? or only stacks of money?
  • corn, what about other produce?

here's a list of items that did not work:
beetroot, grapes, tomatoes, corn, carrots,
green beans, onion, garlic clove, potato,
peper, garlic, honey, mulch,
cucumber, raspberries, pea pod, blueberries plantable (the ones from bushes work),
rhubarb, chilis, pepercorn, rye seeds, oat seeds,
rice grains, cocoa and coffee beans,
raw latex, rubber
pumpkin and melon slices don't but full fruit is accepted.

related #6

@SwissalpS SwissalpS added the enhancement New feature or request label Feb 20, 2020
@BuckarooBanzay
Copy link
Contributor

I think even groups can be added, maybe a simple group:plant entry can slash most of those items..

@OgelGames
Copy link
Contributor

OgelGames commented Mar 2, 2020

I had a look into this and found that just about everything listed above is already convertible in the upstream version, but that version is missing the output fixes, so I re-fixed it and opened a PR: Lokrates/Biofuel#6

Seeing as Lokrates hasn't been active since June last year, I don't expect the PR to be merged anytime soon, so I copied the updated and fixed version to a separate branch on the pandorabox fork: https://github.com/pandorabox-io/Biofuel/tree/pandorabox

The only other difference is that the output is now vials of biofuel (4 makes 1 bottle), and the speed has been slowed a bit, but that can be easily changed with the new settings if needed.

@OgelGames OgelGames added the Fixed Issue has been fixed/resolved but is waiting for something or needs testing label Mar 2, 2020
@SwissalpS
Copy link
Contributor Author

the output is now vials of biofuel (4 makes 1 bottle),

So the refineries need to be rebuilt to add another autocrafter? That's a risky change. :/

@OgelGames
Copy link
Contributor

OgelGames commented Mar 2, 2020

That's a risky change. :/

I was thinking that, but it can be changed to be exactly as it was by adding these settings:

biomass_input = 4
fuel_production_time = 4
refinery_output = true

See here: https://github.com/pandorabox-io/Biofuel/blob/updated/settingtypes.txt

@SwissalpS
Copy link
Contributor Author

Yes refinery_output = true is the important setting in my view.
Production time was 4, it wouldn't break a system completely if speed was halved since cans are not used in any subsequent recipe.

Make sure the minetest.conf settings are updated first, then merge the new version otherwise we have the 'problem' of vials existing in game ;) (minetest.conf needs admin action)

@BuckarooBanzay
Copy link
Contributor

I had a look into this and found that just about everything listed above is already convertible in the upstream version, but that version is missing the output fixes, so I re-fixed it and opened a PR: Lokrates/Biofuel#6

Looks good 👍

So the refineries need to be rebuilt to add another autocrafter? That's a risky change. :/

Should we really be backward compatible here? The biofuel was op to begin with anyway...

Seeing as Lokrates hasn't been active since June last year, I don't expect the PR to be merged anytime soon

Yeah, he takes his time usually but comes around eventually...

Make sure the minetest.conf settings are updated first

The final minetest.conf is a result of this file:
https://github.com/pandorabox-io/pandorabox.io/blob/master/minetest.conf

And one containing the keys (not checked into git)

The final config is generated with this:
https://github.com/pandorabox-io/pandorabox.io/blob/master/generate-config.sh

But this can only be done on the shell/ssh and is not automated yet.
I can add the settings and execute script if this is ready (looks like it though...)

@OgelGames
Copy link
Contributor

Should we really be backward compatible here? The biofuel was op to begin with anyway...

Well personally I'd be fine with the new system, the only sticking point really is the factories that have been built on the original system.

BuckarooBanzay added a commit that referenced this issue Mar 4, 2020
@BuckarooBanzay
Copy link
Contributor

I added the settings for compatibility, lets start with that i guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fixed Issue has been fixed/resolved but is waiting for something or needs testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants