Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jumpdrive get_content_id crash #489

Closed
BuckarooBanzay opened this issue Apr 13, 2020 · 3 comments
Closed

jumpdrive get_content_id crash #489

BuckarooBanzay opened this issue Apr 13, 2020 · 3 comments

Comments

@BuckarooBanzay
Copy link
Contributor

2020-04-13 07:14:16: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback node_on_receive_fields(): Unknown node: ropes:rope_top
2020-04-13 07:14:16: ERROR[Main]: stack traceback:
2020-04-13 07:14:16: ERROR[Main]: 	[C]: in function 'get_content_id'
2020-04-13 07:14:16: ERROR[Main]: 	/data/world//worldmods/ropes/functions.lua:54: in function 'destroy_rope'
2020-04-13 07:14:16: ERROR[Main]: 	/data/world//worldmods/jumpdrive/compat/ropes.lua:53: in function 'ropes_compat'
2020-04-13 07:14:16: ERROR[Main]: 	/data/world//worldmods/jumpdrive/compat/compat.lua:78: in function 'target_region_compat'
2020-04-13 07:14:16: ERROR[Main]: 	/data/world//worldmods/jumpdrive/move/move.lua:90: in function 'move'
2020-04-13 07:14:16: ERROR[Main]: 	/data/world//worldmods/jumpdrive/engines/default_jump.lua:138: in function 'execute_jump'
2020-04-13 07:14:16: ERROR[Main]: 	/data/world//worldmods/jumpdrive/engines/default.lua:182: in function </data/world//worldmods/jumpdrive/engines/default.lua:121>

@OgelGames
Copy link
Contributor

OgelGames commented Apr 13, 2020

ropes:rope_top is not a registered node, it was removed here: minetest-mods/ropes@52a32fe#diff-8bacab8c9150cd80c4b8cafebe962706L162

I think all that needs to be done to fix it is remove ropes:rope_top from here: https://github.com/mt-mods/jumpdrive/blob/1f8f4329f0abd24484e346cee669eb12e4a7ce44/compat/ropes.lua#L2

Edit: Seems to be a bit more complicated than I thought, due to how the code works...

@OgelGames OgelGames removed the 5.2.0 label Apr 13, 2020
@BuckarooBanzay
Copy link
Contributor Author

Edit: Seems to be a bit more complicated than I thought, due to how the code works...

Thanks for checking that out, i opened an issue upstream:
minetest-mods/ropes#19

I also reverted the engine back to 5-something until all issues are fixed, this is quite the whack-a-mole on every update with those issues 😖

@BuckarooBanzay
Copy link
Contributor Author

disabled rope-cleanup in the jumpdrive mod.
I think the problem is actually on the jumpdrive part, it calls ropes.destroy_rope() with the rope_top item and as far as i can see this isn't done anywhere in the ropes-mod:

#  grep ropes.destroy_rope . -Rn
./ropeladder.lua:76:		ropes.destroy_rope(pos_below, {"ropes:ropeladder", "ropes:ropeladder_bottom", "ropes:ropeladder_falling"})
./ropeladder.lua:182:			ropes.destroy_rope(pos_below, {'ropes:ropeladder', 'ropes:ropeladder_bottom', 'ropes:ropeladder_falling'})
./ropeboxes.lua:167:			ropes.destroy_rope(pos_below, {'ropes:rope', 'ropes:rope_bottom'})
./functions.lua:46:ropes.destroy_rope = function(pos, nodes)
./functions.lua:95:		ropes.destroy_rope(pos, {middle_node, bottom_node})

Follow-up: mt-mods/jumpdrive#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants