is_ground_content

[SwissalpS]

Many node definitions seem to have not set is_ground_content to false.
This means jumping a ship near mapblocks that haven't been generated yet, can lead to loss of ships or at least parts of it.
Credit to Huhhila for suffering this, tracking down the cause and pointing it out.

I've opened this issue to track the progress of PRs to the various mods that are affected. Also to discuss which we might add to pandorabox_custom because some repos are very slow to accept PRs.

I used this postool branch to make the list

nonGroundContent.txt (680kB)

The above list includes legitimate ground content too, of course.

Adding the flag to all circular saw cuts and cnc nodes will already slim it down drastically.
Priority should maybe be given to technic and pipeworks mods.

reference links:

• modding tips minetest.net
• lua_api.md search for "is_ground_content"
• deep dive and related links: Please document current status of is_ground_content and how to use it safely to place schematics (with it) in register_on_generated callbacks minetest/minetest#11125

[BuckarooBanzay]

A more radical (and maybe simpler) alternative to setting that in every mod would be to override this in pandorabox_custom on every registered node (except stone of course)

[SwissalpS]

As a radical interum measure yes.
There are a lot of legitimately is_ground_content nodes like dirt, corium, water, air, ignore, lava, etc., etc.

once technic, pipeworks, circular_saw and mesecons are dealt with, the non-ground-content-list will shrink drascically.

I think it's good for mod-devs to think about this and add it, no rush though.

[SwissalpS]

I've also PRed

• mobs (meatblocks and spawner)
• mobs_animal (egg, honeyblock and beehive)
• mobs_monster (cobweb)

[SwissalpS]

FYI, I've also started working on mods that pandorabox isn't using but referencing them to this thread to keep everything under one place.

There are still a few mods that pandorabox uses that I haven't PRed yet: advtrains* is the big one.

[SwissalpS]

Here's the current list

nonGroundContent20240302.txt (51kB)

(roughly 13 times smaller already)

[SwissalpS]

PRed 10+1's bakedclay (leaving flowers untouched to stay in sync with MTG default flowers)