Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to teleport on right-click #1

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Add ability to teleport on right-click #1

merged 1 commit into from
Aug 21, 2019

Conversation

OgelGames
Copy link

Adds settings option to allow teleportation by right-clicking the beacon, instead of automatic teleportation after a short time.

To enable the new functionality "telemosaic_right_click_teleport = true" must be added to minetest.conf, otherwise it will default to automatic teleportation.

Fixes issue: pandorabox-io/pandorabox.io#286

@thomasrudin thomasrudin merged commit a056353 into mt-mods:master Aug 21, 2019
@thomasrudin
Copy link

Ooh, that was fast 😄 thx

thomasrudin pushed a commit to pandorabox-io/pandorabox-mods that referenced this pull request Aug 21, 2019
@OgelGames
Copy link
Author

Yeah, that's because I had already done some experimenting with it a couple days ago, so basically all I did today was fork the repo, refine my code a bit, and make the PR 😄

@thomasrudin
Copy link

@OgelGames i added that on the test-server (test.pandorabox.io) rightclick does not seem to work there (haven't tried it in singleplayer though)

@OgelGames
Copy link
Author

Did you add the required setting as mentioned above? I just tried it on the test-server, and it's still working as normal (automatic teleportation), which is the default when the setting is not added.

@thomasrudin
Copy link

Oh, i forgot the setting :P sorry...
But now it only works if you stand on the telemosaic and right-click...

I expected it to work if you stand on it or right-click on it. :P
Anyways, this looks good nonetheless, i hope you are ok with it when i extend on your feature later 😄

@OgelGames
Copy link
Author

OgelGames commented Aug 22, 2019

I expected it to work if you stand on it or right-click on it. :P

When I was adding the right-click I was thinking it was more to prevent getting teleported accidentally (which has happened to me more than a few times), as well preventing getting stuck teleporting because of lag, but now you mention it, not having to stand on it would make more sense...

I'll see what I can do tomorrow, and will make another PR if I find a way to change it 😉

i hope you are ok with it when i extend on your feature later

Of course 😄

@OgelGames
Copy link
Author

Done: #2

Actually much simpler to do than I thought, only a few extra lines of code 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants