Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the dialog used for displaying network request / response payloads #38

Closed
pandulapeter opened this issue Sep 2, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@pandulapeter
Copy link
Owner

pandulapeter commented Sep 2, 2020

Required features:

  • Formatting the JSON should be done in the background to avoid blocking the UI thread in case of large payloads.
  • Controls for showing request / response metadata (headers, timestamp, duration) should be on the UI.
  • The copy feature is currently based on Android's default text selection UX which is cumbersome with JSON-s.
  • Expanding / collapsing JSON objects / arrays would be very helpful.
  • Links should be clickable.
  • Scrollbars are also needed.
@pandulapeter pandulapeter changed the title [Improvement] Replace the dialog used for displaying network request / response payloads. Rewrite the dialog used for displaying network request / response payloads. Sep 2, 2020
@pandulapeter pandulapeter self-assigned this Sep 2, 2020
@pandulapeter pandulapeter added the enhancement New feature or request label Sep 2, 2020
@pandulapeter pandulapeter changed the title Rewrite the dialog used for displaying network request / response payloads. Rewrite the dialog used for displaying network request / response payloads Sep 8, 2020
@pandulapeter
Copy link
Owner Author

Some of these improvements were implemented in v2.0.2.

@percula
Copy link
Contributor

percula commented Oct 6, 2020

Thanks for this amazing library! Can you please add the ability to share all network activity? This would be particularly useful for communicating with QA engineers who might not know which specific network call is the problem.

@pandulapeter
Copy link
Owner Author

Great idea, thanks! I'm working on a separate module which will bring up a bug reporting UI, where QA engineers can select attachments to add to the bug report, such as screenshots, logs, or, as you mentioned, network activity logs. I have to find a good way that works for any app (probably file attachments as the clipboard has a size limitation). So this might take a few weeks, but it's definitely on the TODO list!

@pandulapeter
Copy link
Owner Author

Closing this as release 2.1.2 introduced a file-based sharing solution which solves most of the issues (expand - collapse directly in the dialog feels like an overkill for now). The ability to share multiple network logs will be part of the BugReportModule which is being worked on on a separate branch.

@pandulapeter
Copy link
Owner Author

@percula Release 2.2.0 introduces the BugReportButtonModule which can be used for sending multiple log files, even all of them. Check it out if you're still interested :) It should open a screen that looks something like this:

bugReport

@percula
Copy link
Contributor

percula commented Oct 19, 2020

@pandulapeter Wonderful! I'll definitely be adding this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants