Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fix OGP URLs, see #471 #476

Merged

Conversation

dfsp-spirit
Copy link
Contributor

@dfsp-spirit dfsp-spirit commented Jan 8, 2024

Minor fix of typo in EGL URL, as reported in #471.

Description

Related issue: #471

Motivation and context

Broken URL.

How has this been tested?

  • Tested new versus old URL in webbrowser.
  • ran tests locally (hatch run test tests/api), which succeeded, but it also did before this fix. Adding a new test for this trivial change seems exaggerated though.

Screenshots (if appropriate)

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@huberrob huberrob merged commit e8953e0 into pangaea-data-publisher:master Jan 8, 2024
2 of 3 checks passed
Copy link

github-actions bot commented Jan 8, 2024

📋 Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
. 51% 35%
config 100% 100%
controllers 85% 56%
evaluators 59% 34%
harvester 63% 52%
helper 64% 54%
models 80% 87%
Summary 69% (6494 / 9461) 59% (2771 / 4672)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants