pangea-node-sdk: update typescript to v5.4.5 (GEA-14160) #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenany
force-pushed
the
kenany/replace-ts-jest
branch
2 times, most recently
from
ec409c1
to
1079c66
Compare
cj-f
previously approved these changes
Jun 14, 2024
kenany
force-pushed
the
kenany/replace-ts-jest
branch
from
1079c66
to
99d5e30
Compare
ts-jest does not work with TS v5.2 and above, which is holding us back from updating TS. Replace it with the swc/jest.
kenany
force-pushed
the
kenany/replace-ts-jest
branch
from
99d5e30
to
259c56f
Compare
cj-f
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace ts-jest, which was holding us back from updating TS, with swc/jest. Then update TS to v5.4.5.
The config file had to be changed to a plain JS one because otherwise the same error remains. IMO this is an OK compromise, since it's just a config file, if it means newer TS for the rest of the project.