Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont require tqdm #784

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Dont require tqdm #784

merged 3 commits into from
Sep 14, 2022

Conversation

aaronspring
Copy link
Collaborator

Description

Closes #780

@aaronspring aaronspring added cleanup dependencies Pull requests that update a dependency file labels Sep 14, 2022
@github-actions
Copy link

Checkout your PR on Binder. Open the console and pip install -e . before using the notebooks to use climpred from this PR.

@aaronspring aaronspring self-assigned this Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #784 (0593102) into main (dafd1f3) will decrease coverage by 1.03%.
The diff coverage is 90.31%.

@@            Coverage Diff             @@
##             main     #784      +/-   ##
==========================================
- Coverage   93.80%   92.77%   -1.04%     
==========================================
  Files          59       59              
  Lines        6235     6244       +9     
==========================================
- Hits         5849     5793      -56     
- Misses        386      451      +65     
Impacted Files Coverage Δ
climpred/horizon.py 96.55% <ø> (ø)
climpred/options.py 81.48% <ø> (ø)
climpred/tests/test_hindcast_prediction.py 100.00% <ø> (ø)
climpred/tests/test_logging.py 100.00% <ø> (ø)
climpred/bootstrap.py 80.21% <72.61%> (-10.67%) ⬇️
climpred/alignment.py 91.13% <73.68%> (-5.74%) ⬇️
climpred/checks.py 95.79% <83.33%> (+0.03%) ⬆️
climpred/tests/test_HindcastEnsemble_class.py 96.51% <85.71%> (-3.49%) ⬇️
climpred/classes.py 93.36% <88.29%> (-0.15%) ⬇️
climpred/utils.py 90.00% <90.00%> (-0.40%) ⬇️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aaronspring aaronspring merged commit a1dfd50 into main Sep 14, 2022
@aaronspring aaronspring deleted the tqdm_not_required branch October 1, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make tqdm optional
1 participant