-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump r2d version on prod #47
Conversation
Though the deployment CI passed, there seems to be a problem with staging:
This seems to be entirely related to our recent addition of dind to the chart. I suspect @yuvipanda will know what this means but I'm at a loss. |
Are your prod and staging deployments in the same cluster? That means the DIND daemonsets for both deployments are racing for access to /var/run/dind on all your nodes, causing failures like this. Solution would be to make the host dind path something like /var/run/dind/{{Release.Name}}/docker.sock or something like that. |
@yuvipanda - yes, both prod and staging are in the same GKE cluster (different namespaces). Is this not how its done with mybinder.org? Can you, by chance, point to an example where the host dind path is set? Googling isn't getting me anywhere. |
I'm also wondering if this namespace isolation of dind shouldn't happen in the binderhub chart? I'm thinking it would be best set here: https://github.com/jupyterhub/binderhub/blob/master/helm-chart/binderhub/templates/dind/daemonset.yaml |
https://github.com/jupyterhub/binderhub/blob/master/helm-chart/binderhub/templates/dind/daemonset.yaml#L34 Should let you do it I think. On mybinder we have separate clusters for staging and prod |
Thanks @yuvipanda - seems to be working on staging, giving it a try on prod. |
@@ -16,6 +16,9 @@ binderhub: | |||
hosts: | |||
- binder.pangeo.io | |||
|
|||
dind: | |||
hostSocketDir: /var/run/dind/prod/docker.sock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be /var/run/dind/prod, without the docker.sock, since it is only specifying the socket directory and not the socket itself.
I think you also need to set |
I think you might need to ssh to your nodes and rm -rf the current stuff under /var/run/dind before merging the changes, since you'll already have a directory created at /var/run/dind/staging/docker.sock, so can't make a socket there |
No description provided.