Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add util to build tripolar grid #228

Merged
merged 12 commits into from
Jan 27, 2023
Merged

add util to build tripolar grid #228

merged 12 commits into from
Jan 27, 2023

Conversation

raphaeldussin
Copy link
Contributor

PR #223 uses data files that are too big, this PR adds code to build a simple (simplistic?) tripolar grid for testing purposes only. PR #223 could then use this function to generate its own tests with synthetic data from a tripolar grid to a regular grid using some type of field (e.g. sin(lat) )

@raphaeldussin
Copy link
Contributor Author

@huard @aulemahal this implements the simple_tripolar_grid function whose purpose you've already figured out. The remaining routines are copied from a GFDL package rather than adding a new dependency for very little code. This will help solve issues regarding testing with data from tripolar grids.

Copy link
Contributor

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest making bipolar_projection and generate_bipolar_cap_mesh private functions.

xesmf/util.py Outdated Show resolved Hide resolved
xesmf/util.py Outdated Show resolved Hide resolved
@raphaeldussin
Copy link
Contributor Author

@aulemahal friendly reminder

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have much knowledge of tripolar grids, but this code looks fine!

@raphaeldussin raphaeldussin merged commit 11b942b into master Jan 27, 2023
@raphaeldussin raphaeldussin deleted the tripolar_util branch January 27, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants