-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and doc - fix for DataArrays #230
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@raphaeldussin Do you know what are those "build (3.7) Expected" entries in the checks? I think they never get updated since I changed the build names, but I can't find where these entries are set to update them... Maybe @Zeitsperre knows about this. |
In the branch settings, at some point, someone with maintainer access marked some CI actions as necessary in order to merge to the main development branch. This need to be updated to use the existing CI jobs instead. |
Ok thanks @Zeitsperre ! I don't have access to that I believe. |
Removed expected builds from checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @aulemahal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done !
Fixes #224, fixes #225 , fixes #227.
DataArray
inRegridder
andSpatialAverager
for bothds_in
andds_out
, they are simply converted to_temp_dataset
before doing anything. A trivial test was added.and 3.11. A specific version of ESMpy was pinned for each version.ESMpy
8.4