Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and doc - fix for DataArrays #230

Merged
merged 16 commits into from
Jan 23, 2023
Merged

Update CI and doc - fix for DataArrays #230

merged 16 commits into from
Jan 23, 2023

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Jan 23, 2023

Fixes #224, fixes #225 , fixes #227.

  • Accepts DataArray in Regridder and SpatialAverager for both ds_in and ds_out, they are simply converted to _temp_dataset before doing anything. A trivial test was added.
  • Expands the CI jobs to python 3.10 and 3.11. A specific version of ESMpy was pinned for each version.
    • 3.11 was removed as numba (a dependency) is not yet compatible
    • I also removed the CI trigger on "push" (except for master). It was triggering all builds in duplicate when opening a pull request. Now, only pull requests and the master branch will have CI runs.
    • Push the upstream build to use python 3.10.
  • Updated the installation page
    • Remove reference to specific python version
    • Remove warning for ESMF and mpi. I believe this was an issue before we put esmpy>=8.0 as a dependency.
    • Add new deps.
    • Remove note that pip is limited to 0.3
    • Add notes about ESMpy 8.4
  • Updated the doc
    • Bumped the version number to 0.7.0.
    • Dynamical year and add "and the xESMF development team" to the copyright.
    • Mock import for esmpy.

@aulemahal
Copy link
Collaborator Author

@raphaeldussin Do you know what are those "build (3.7) Expected" entries in the checks? I think they never get updated since I changed the build names, but I can't find where these entries are set to update them...

Maybe @Zeitsperre knows about this.

@Zeitsperre
Copy link
Contributor

@raphaeldussin Do you know what are those "build (3.7) Expected" entries in the checks? I think they never get updated since I changed the build names, but I can't find where these entries are set to update them...

Maybe @Zeitsperre knows about this.

In the branch settings, at some point, someone with maintainer access marked some CI actions as necessary in order to merge to the main development branch. This need to be updated to use the existing CI jobs instead.

@aulemahal
Copy link
Collaborator Author

Ok thanks @Zeitsperre ! I don't have access to that I believe.

@huard
Copy link
Contributor

huard commented Jan 23, 2023

Removed expected builds from checks

@aulemahal aulemahal marked this pull request as ready for review January 23, 2023 19:15
Copy link
Contributor

@raphaeldussin raphaeldussin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @aulemahal

Copy link
Contributor

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done !

@huard huard merged commit e8b9de7 into master Jan 23, 2023
@huard huard deleted the fix-224-225-227 branch January 23, 2023 19:38
@huard huard mentioned this pull request Feb 6, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants