Modernize the package a bit #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huard I also want to implement linting with ruff but I'll leave that for another PR. For now, we still cannot publish on PyPI b/c someone with admin rights to this repo needs to add the PyPI token to the repo secrets. |
|
Ok, give me 5 minutes, I'll get the token. |
|
Done, there is now a |
huard
approved these changes
Apr 3, 2023
Co-authored-by: David Huard <huard.david@ouranos.ca>
I find testpypi an overkill. Hopefully we test the tarball enough in our CIs to upload directly to PyPI. PS: if you want to tag a new release after this PR is merged we can test the autopublish. |
|
Thanks ! |
Merged
raphaeldussin
pushed a commit
that referenced
this pull request
Apr 24, 2023
* udpate PyPI GHA * remove setuptools_scm_git_archive * bump to 3.8 b/c that's what is used as min * update and add config * fix identation * run pre-commit * move some configs to pyproject.toml * move setup.py to pyproject.toml * don't use main * fix typo * let's rely only on the version file * tweak for a smaller sdist * fix license * list tests * don't list esmpy * no numba on py311 * drop py37 from the CIS * py38 as min * run pre-commit * Update .github/workflows/pypi.yaml Co-authored-by: David Huard <huard.david@ouranos.ca> --------- Co-authored-by: David Huard <huard.david@ouranos.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR: